add ability to provide a digest for haproxy#524
add ability to provide a digest for haproxy#524LaurentGoderre wants to merge 2 commits intovectordotdev:developfrom
Conversation
This follows the same pattern as the image syntax for the vector container
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2d51f79e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {{- else if $tag -}} | ||
| {{- printf "%s:%s" $repo $tag -}} | ||
| {{- end }} |
There was a problem hiding this comment.
This helper stops at else if $tag and never handles the case where both haproxy.image.tag and haproxy.image.sha/digest are empty, so it returns an empty string. Because deployment.yaml now uses this helper for image, that path renders image: "", which Kubernetes rejects for a container spec. The comment above this function also states a repo:<Chart.AppVersion> fallback, so the current implementation breaks that advertised behavior.
Useful? React with 👍 / 👎.
2 participants
This follows the same pattern as the image syntax for the vector container